[lldb] Remove Base::unique from NonNullSharedPtr#169130
Merged
Conversation
It seems like this fails on macOS with C++20
Member
|
@llvm/pr-subscribers-lldb Author: Keith Smiley (keith) ChangesIt seems like this fails on macOS with C++20 Full diff: https://github.com/llvm/llvm-project/pull/169130.diff 1 Files Affected:
diff --git a/lldb/include/lldb/Utility/NonNullSharedPtr.h b/lldb/include/lldb/Utility/NonNullSharedPtr.h
index d084e79759d1b..e0da293b9629e 100644
--- a/lldb/include/lldb/Utility/NonNullSharedPtr.h
+++ b/lldb/include/lldb/Utility/NonNullSharedPtr.h
@@ -56,7 +56,6 @@ template <typename T> class NonNullSharedPtr : private std::shared_ptr<T> {
using Base::operator*;
using Base::operator->;
using Base::get;
- using Base::unique;
using Base::use_count;
using Base::operator bool;
|
Member
Author
|
this was fallout from #168624, ptal @JDevlieghere here's the full error: |
JDevlieghere
approved these changes
Nov 22, 2025
Member
JDevlieghere
left a comment
JDevlieghere
left a comment
There was a problem hiding this comment.
LGTM, apparently that method was deprecated in C++17 and removed in C++20 (https://en.cppreference.com/w/cpp/memory/shared_ptr/unique.html).
🐧 Linux x64 Test Results
|
aadeshps-mcw
pushed a commit
to aadeshps-mcw/llvm-project
that referenced
this pull request
Nov 26, 2025
It seems like this fails on macOS with C++20
Priyanshu3820
pushed a commit
to Priyanshu3820/llvm-project
that referenced
this pull request
Nov 26, 2025
It seems like this fails on macOS with C++20
augusto2112
pushed a commit
to augusto2112/llvm-project
that referenced
this pull request
Dec 3, 2025
It seems like this fails on macOS with C++20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like this fails on macOS with C++20